refactor: Move the paraview plugin and create a VTK filter for CreateConstantAttributePerRegion #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckdataset if it exist
Co-authored-by: paloma-martinez <[email protected]>
…inBaville/feature/VTK_filter_and_PVCreateConstantAttributePerRegion Update to last version of geos-mesh utils
Base automatically changed from
RomainBaville/feature/update_geos-mesh_utils
to
main
August 6, 2025 18:24
paloma-martinez
changed the title
…eConstantAttributePerRegion Update to main.
…eConstantAttributePerRegion
Comment on lines
+277
to
+291
| def _setPieceRegionAttribute( self: Self ) -> None: | ||
| """Set the attribute self.onPoints and self.onBoth. | ||
|
|
||
| self.onPoints is True if the region attribute is on points, False if it is on cells, None otherwise. | ||
|
|
||
| self.onBoth is True if a region attribute is on points and on cells, False otherwise. | ||
| """ | ||
| self.onPoints: Union[ bool, None ] = None | ||
| self.onBoth: bool = False | ||
| if isAttributeInObject( self.mesh, self.regionName, False ): | ||
| self.onPoints = False | ||
| if isAttributeInObject( self.mesh, self.regionName, True ): | ||
| if self.onPoints is False: | ||
| self.onBoth = True | ||
| self.onPoints = True |
There was a problem hiding this comment.
Looking at FillPartialArrays implementation of the same method, this one seems misleading, especially using the term "set" when no argument is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the repository refactoring, this will consists in three main tasks:
close #106