feat: VTK filters for mesh-doctor #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_filters_for_mesh_doctor
…_filters_for_mesh_doctor
…_filters_for_mesh_doctor
alexbenedicto
changed the title
There was a problem hiding this comment.
The code is good and essay to read but some typing and docstrings are missing.
More over, I don't understand some points :
- why the check check_fractures is not also check in the function AllChecks.
- why the doc is duplicaded (a file.rst and a doc part in the filter files)
- why you use the VTKPythonAlgorithmBase for the filter while the mesh exists already, and with the VTKPythonWrapping we use, the vtk objects are pointers. Meshes can be updated without the VTKPythonAlgorithmBase pipline.
- why in the filter you use member function to set some variable (mesh, tolerance ...) while they can set as arguments.
At least, the function get_vtk_constant_str in genericHelpers needs to be updated. For now it can return a false name because severals VTK_CONSTANT refers to the same number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80