Skip to content

Add zlib-ng 2.1.6, remove zlib#75

Draft
mathomp4 wants to merge 11 commits intomainfrom
feature/mathomp4/add-zlib-ng-2.0.6
Draft

Add zlib-ng 2.1.6, remove zlib#75
mathomp4 wants to merge 11 commits intomainfrom
feature/mathomp4/add-zlib-ng-2.0.6

Conversation

@mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Nov 4, 2022

Closes #15

This PR moves ESMA-Baselibs from zlib (which is stable, but might have issues with newer hardware, etc.) to zlib-ng which is an actively maintained and developed library which seems to provide better performance.

Tests show this is zero-diff for GEOS. It all runs just fine.

Only tested on discover. Need to test on macOS.

@mathomp4 mathomp4 added the new library Add a new library label Nov 4, 2022
@mathomp4 mathomp4 self-assigned this Nov 4, 2022
@mathomp4 mathomp4 changed the title Add zlib-ng 2.0.6, remove zlib Add zlib-ng 2.1.3, remove zlib Jul 21, 2023
@mathomp4 mathomp4 marked this pull request as ready for review July 28, 2023 17:21
@mathomp4 mathomp4 marked this pull request as draft July 28, 2023 17:22
@mathomp4 mathomp4 mentioned this pull request Sep 20, 2023
# Conflicts:
#	.gitmodules
#	CHANGELOG.md
#	GNUmakefile
#	README.md
#	zlib
@mathomp4 mathomp4 changed the title Add zlib-ng 2.1.3, remove zlib Add zlib-ng 2.1.6, remove zlib Feb 22, 2024
@mathomp4
Copy link
Member Author

This fails on macOS. Or, rather, it builds just fine on macOS, but nothing can link to it. For example with curl:

configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lz -lm

and from curl/config.log:

configure:34993: $? = 0
configure:34993: ./conftest
dyld[61616]: Library not loaded: @rpath/libz.1.dylib
  Referenced from: <39FAB902-1943-35CE-A6E2-A9ED30F8C08F> /Users/mathomp4/Baselibs/ESMA-Baselibs-7.19.0-TEST/src/curl/conftest
  Reason: no LC_RPATH's found
./configure: line 2529: 61616 Abort trap: 6           ./conftest$ac_exeext
configure:34993: $? = 134
configure: program exited with status 134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new library Add a new library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add zlib-ng

1 participant