v12: Replace conservative with regrid_method in HISTORY templates #812
Open
mathomp4 wants to merge 1 commit intofeature/sdrabenh/gcm_v12from
Open
v12: Replace conservative with regrid_method in HISTORY templates #812mathomp4 wants to merge 1 commit intofeature/sdrabenh/gcm_v12from
mathomp4 wants to merge 1 commit intofeature/sdrabenh/gcm_v12from
Conversation
Replace all instances of the deprecated collection.conservative syntax with the more flexible collection.regrid_method syntax across all HISTORY template files. This change converts: - conservative: 0 -> regrid_method: 'BILINEAR' - conservative: 1 -> regrid_method: 'CONSERVE' providing better flexibility for regridding configuration. This was prompted by @rtodling noticing we still had a mix, though @atrayano did confirm they do the same thing. This is a bit confusing to the end user as we should have a consistent style in HISTORY.rc. Indeed, some files mixed the two as they needed methods like BILINEAR_MONOTONIC which are only through regrid_method. NOTE: The regrid_method syntax came in MAPL 2.22 (2022-06-24) so we are safe.
mathomp4
added
the
0 diff
mathomp4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all instances of the deprecated collection.conservative syntax with the more flexible collection.regrid_method syntax across all HISTORY template files. This change converts:
providing better flexibility for regridding configuration.
This was prompted by @rtodling noticing we still had a mix, though @atrayano did confirm they do the same thing. This is a bit confusing to the end user as we should have a consistent style in HISTORY.rc. Indeed, some files mixed the two as they needed methods like BILINEAR_MONOTONIC which are only through regrid_method.
NOTE: The regrid_method syntax came in MAPL 2.22 (2022-06-24) so we are safe.