Conversation
|
Hmmm. I don't think this is meant to go into From the git logs this seems to be based off of the I think we need to do a couple things. First, @rtodling should tag off of this branch. But then this PR should go to |
|
I just changed the base to be to https://github.com/GEOS-ESM/GMAO_Shared/pull/381/commits two from @rtodling and two from @rlucches @mathomp4 the problem w/ changing the base is that GEOSadas v5.42.7 is not on main! |
|
I changed the name of this PR to something sensible. I have no idea how changes to hermes and transf ended up in this PR. I did not change anything there. The only change I made was to r_dist and perhaps the CHANGELOG. It looks like those other changes are from Ricardo, but I am not sure how they got lumped into #381. |
|
Note to @rtodling: this didn't affect the GEOSgcm probably because we don't use these codes. So, if you are happy, you can press the Merge button. |
|
Not sure why CI is unhappy. I just pushed an update |
r_dist is used in post-processing utilities in the ops implementation of FP. The version in the tag still had a construct that worked under SLES-12, but fails under SLES-15. This has been fixed.