Lazily parse index per-chromosome #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the BAM file used here has a 60Mb BAI file |
cmdcolin
force-pushed
the
mem_usage_lazy_index
branch
from
fb7354e to
275cda9
Compare
|
(this was somewhat of an exercise in understanding memory heap snapshots, as lead up to tackling memory leak from layout in GMOD/jbrowse-components#4860) |
cmdcolin
force-pushed
the
mem_usage_lazy_index
branch
2 times, most recently
from
3d0ed98 to
ec8b88c
Compare
cmdcolin
force-pushed
the
mem_usage_lazy_index
branch
from
ec8b88c to
7f2974b
Compare
|
this PR also gets fairly close to allowing "BAI indexes" because it creates the concept of parsing each chromosome via a byte offset into the file. an external bai indx can provide the byte offsets now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in a reduction in memory usage for the web worker for large e.g. BAI files
Webworker heap snapshot:
Before this PR: very slow to even create a snapshot, 478Mb
After this PR: very fast to create a snapshot, 149Mb total
screenshot showing before and after snapshots
This PR does not try to cache the return value, so could be worth profiling whether that would be worth it, but i think the memory savings do help