Swap sam-text in modal docs for text input#229
Merged
yerramshilpa merged 7 commits intomasterfrom Feb 14, 2019
Merged
Conversation
yerramshilpa
approved these changes
Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are having an issue we can't resolve due to RxJS compatibility issues until after the close of the sprint. However, we need to deploy this modal fix this sprint, and the team can't validate without dealing with the text issue.
After the next sprint starts, we can merge GSA/sam-ui-elements#258 and replace the input with sam-text again.
There are very few visual changes regardess, since the text didn't use the complex form features of the label wrapper, and both use the underlying styles from USWDS.