Skip to content

ang 10 compat#528

Open
diego-ruiz-rei wants to merge 5 commits intoGSA:angular-10from
REI-Systems:ang-10-compat
Open

ang 10 compat#528
diego-ruiz-rei wants to merge 5 commits intoGSA:angular-10from
REI-Systems:ang-10-compat

Conversation

@diego-ruiz-rei
Copy link
Copy Markdown
Contributor

Description

updates needed for angular 10 for SFE

  • convert renderer(1) to renderer2
  • picker.component.ts already extends formcontrol which has a disabled property, ivy flagged a duplicate property that wasn't used
  • expansion panel, expanded accessor now available and we don't need to track expanded state by presence of css class

Motivation and Context

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

yerramshilpa and others added 5 commits October 7, 2020 17:01
* focus out changes

* updated package version
* Update sidenav.component.ts

Adding Nav Service to Isolate Nav component with each service

* fix clear issue on autocomplete

* revert sidenav change
@diego-ruiz-rei diego-ruiz-rei changed the base branch from master to angular-10 December 2, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants