Skip to content

fix NPE in EventHandler#postPresetNotice #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dream-Master merged 1 commit into from
Feb 22, 2026
Merged

fix NPE in EventHandler#postPresetNotice #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/betterquesting/handlers/EventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
import betterquesting.api.questing.IQuest;
import betterquesting.api.questing.party.IParty;
import betterquesting.api.storage.BQ_Settings;
import betterquesting.api.utils.BigItemStack;
import betterquesting.api.utils.UuidConverter;
import betterquesting.api2.cache.QuestCache;
import betterquesting.api2.cache.QuestCache.QResetTime;
Expand Down Expand Up @@ -332,8 +333,9 @@ public void onLivingUpdate(BQLivingUpdateEvent event) {
// TODO: Create a new message inbox system for these things. On screen popups aren't ideal in combat
private static void postPresetNotice(IQuest quest, EntityPlayer player, int preset) {
if (!(player instanceof EntityPlayerMP)) return;
ItemStack icon = quest.getProperty(NativeProps.ICON)
.getBaseStack();
final BigItemStack stack = quest.getProperty(NativeProps.ICON);
if (stack == null) return;
ItemStack icon = stack.getBaseStack();
UUID questId = QuestDatabase.INSTANCE.lookupKey(quest);

String questName = quest.getProperty(NativeProps.NAME);
Expand Down