Genetics UI rework and code refactoring#91
Genetics UI rework and code refactoring#91Luca-Guettinger wants to merge 10 commits intoGTNewHorizons:masterfrom
Conversation
|
These look great! I'm a little sad to see the nice progress animation gone, but well... One thing for the Sequencer, I think having the line about whose gene library the genes will be sequenced into should stay! Or well, the team name at least! |
|
Oh, and one thing for the Gene Bank: Can you click TAB and toggle the search like that? Would be a little QoL feature |
Yeah, animations are difficult to implement in smaller GUIs. If you have an idea on how to integrate them into a smaller format, I’d love to change that. ^^ I added the “sequenced by” message. Technically, it would have been visible in the owner section, but it’s probably easier to understand what’s happening if there’s explicit text. I’d probably rework that part a bit once gtnhTeams is merged, but until then, this is fine. |
|
shift tab goes back 1, tab goes 1 forward: 2026-04-07.19-34-11.mp4 |
Is there a reason the UIs have to be smaller? Keeping the stye and flavor of Binnie's is important IMO, I don't think that should be discarded for the sake of cleaner code. Also, why are they all blue? |
|
Oh, and one thing for the Gene Bank: Can you click TAB and toggle the search like that? Would be a little QoL feature
Oh, I meant something different. I meant the TAB thing like in the ME Terminal. Where it focuses the search bar when you press TAB. That may be a personal thing tho because I have auto-focus... |
yeah, they shouldn't look like GT machines. They're not GT, they're Binnie's, and they should be most similar to Forestry machines. IMO the original UI is fine to leave as-is, if you want to change the looks that should be a separate PR from the code cleanup and MUI port. |
i did that too, so if you just press tab it automatically hops to the search bar |
alright i will look over the inventories again, i am not sure its a good idea to try and split this up in multiple PRs, a big part of the refactoring was using mui2. do you have the same complaint about the gene bank or is it mostly about the machines? i was kinda unsure about the design from the machines, but i feel like the gene bank is just objectivly better especially considering how the one before had... some big flaws. i will send some more screenshots as soon as i am done |
|
The gene bank change looks fine, except for the scroll bar being much smaller - unsure if it's problematically small without using it tho. |
As someone who enjoys GUI scale 3, small scroll bars are the bane of my existence |
|
Yeah, that’s valid. I’ll see if I can make it bigger and maybe increase the overall window height so there’s more space. |
|
i changed all the inventories: first is the original, the second is the first draft, and the last is the current one: Gene Bank: Isolator: Sequencer: Polymeriser: Inoculator: Analyzer: Incubator: Genepool: |
…Guettinger/Binnie into feature/genetics-ui-rework
@ah-OOG-ah @KleinGrrmpf I adjusted the gene bank, check the PR description for all the updated textures. That turned out to be a surprisingly large amount of pain. |
|
Nice! Were the fluid buffers in the Polymerizer always 550 and 750 mB? I thought it would have been 1B for all of them... Anyway, they look awesome! |
yea no, thats a error, they show full when they are not full, thats a mistake, i am going to adjust it, thanks! |
|
wait no i fixed that, look at the pr description there the right screenshots should be displayed. |
|
Ah, I see. Missed that, sorry! |


Genetics UI Rework
Moving genetics GUIs over to MUI2.
What changed
IMui2MachineGuiProviderinterface so machines can provide MUI2 panelsTileEntityMachinenow implementsIGuiHolder<PosGuiData>, description packet rewritten to NBT syncGeneticsGUI, only Analyst/MasterRegistry/Registry still use the old pathControlGeneandControlGeneScroll, replaced by MUI2 widgets.values()into staticVALUESGeneTracker.getDisplayTracker())fufilledtypo, removed some dead codeScreenshots
Gene Bank:


*the filters are on all pages
Isolator:


Sequencer:


Polymeriser:


Inoculator:


Analyzer:


Incubator:


Genepool:


Acclimatiser:


Splicer:

