Optimize Ring of Mantle ticking#123
Open
DialecticalMaterialist wants to merge 3 commits intoGTNewHorizons:masterfrom
Open
Optimize Ring of Mantle ticking#123DialecticalMaterialist wants to merge 3 commits intoGTNewHorizons:masterfrom
DialecticalMaterialist wants to merge 3 commits intoGTNewHorizons:masterfrom
Conversation
Member
|
I prefer auras that have a duration of 15s that get refreshed at 3 or less seconds remaining |
Author
Why is that? |
Author
|
I changed it so that it now gives you haste with 10 second duration and when there is 1 second or less left it removes it, it also removes it if you run out of mana or when you unequip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23501
Instead of removing and re-adding the haste potion effect every tick it instead now gives you haste with 10 second duration and when there is 1 second or less left it removes it, it also removes it if you run out of mana or when you unequip the ring