Fix Universium shader crash

[sisyphussy]

No longer creates another ShaderProgram that's basically identical to the one in Avaritia

Also a rendering code cleanup (there were some unholy things going on here)

Closes GTNewHorizons/GT-New-Horizons-Modpack#22968

[github-actions]

#13

[glowredman]

Does this change introduce a requirement on a specific min version of Avaritia? If so, please specify this in the @Mod annotation.

[sisyphussy]

If so, please specify this in the @Mod annotation.

Need GTNewHorizons/Avaritia#67 merged first then.

[sisyphussy]

Actually nvm, newer versions are still compatible with older avaritia versions since I'm using the shader from GTNHLib now. It's just older versions not being compatible with newer avaritia versions.

[glowredman]

Then you'll have to

• mark GTNHLib as required mod here (including the appropriate version)
• mark the versions of this mod in Avaritia as incompatible (before:modid@(,lastWorkingVer] or before:modid@(,firstIncompatibleVer))

[sisyphussy]

• mark the versions of this mod in Avaritia as incompatible (before:modid@(,lastWorkingVer] or before:modid@(,firstIncompatibleVer))

wouldn't this mean eternal singularity is a hard dep on avaritia?

[glowredman]

No, before/after are only for load order and (if present) version requirements ("if that mod is present, it must be in this range. Hard deps are either required-after or required-before

[sisyphussy]

Should be fixed now.

[glowredman]

mark the versions of this mod in Avaritia as incompatible (before:modid@(,lastWorkingVer] or before:modid@(,firstIncompatibleVer))

@sisyphussy have you done this? Also, I can't review the rest of the code, this way to complicated for me (idk rendering), sorry :(

[sisyphussy]

@sisyphussy have you done this?

Had it locally, I just wanted to wait for a new release just incase it accidentally gets merged too early. Will commit it now.