Fix crash when golem is placed on dedicated server#48
Closed
sobrinth wants to merge 1 commit intoGTNewHorizons:masterfrom
Closed
Fix crash when golem is placed on dedicated server#48sobrinth wants to merge 1 commit intoGTNewHorizons:masterfrom
sobrinth wants to merge 1 commit intoGTNewHorizons:masterfrom
Conversation
Member
|
I made a fix #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes in #44 registration of several EventHandler classes was moved to the ServerStartEvent.
At least EventHandlerGolem is needed to be registered on both logical sides, when the server is running "remote".
Otherwise when placing a new golem, golem-data is not persisted to the world and then the rendering fails.
Crash in the mentioned issue only happens when playing on a dedicated server.
I'm quite out of touch with Forge for 1.7.10 and where which events are fired, so the following is just a "feeling", but I'm not quite sure that it's correct for the other affected Handlers only being registered on Server as there are several world.isRemote() checks in the contained EventHandlers.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#23000