Fix placing multiple rockets on the same landing pad#128
Open
sbancuz wants to merge 2 commits intoGTNewHorizons:masterfrom
Open
Fix placing multiple rockets on the same landing pad#128sbancuz wants to merge 2 commits intoGTNewHorizons:masterfrom
sbancuz wants to merge 2 commits intoGTNewHorizons:masterfrom
Conversation
Author
|
I can't continue this pr since I don't have access to galaxy space gtnh. If anyone has access and is interested feel free to pick it up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes GTNewHorizons/GT-New-Horizons-Modpack#23799
It seems to be an issue with the placement procedure and not with the backhand mod. When placing a rocket the pad doesn't actually gets filled and waited for a tickUpdate. So if someone places more than one rocket before the tick update it will put multiple.
I say partially since this pr only deals with the placement of the rockets, not the actual dupe. If someone manages to place more than one rocket on the same pad it will still lead to a dupe.
Also this can only cover rocket tiers from 1-3 + cargo