Open
Conversation
brachy84
requested changes
Mar 6, 2026
| return 0.0; | ||
| } | ||
| } | ||
| num = num.replaceAll("\\D+", ""); |
Author
There was a problem hiding this comment.
for this : Improve QOL when a field is numric, remove all non numeric chars onRemoveFocus instead set 0.
Before, when user leave focus
1556e => is set to 0, test55test55 => 0
After
1556e => is set to 1556, test55test55 => 5555
Collaborator
There was a problem hiding this comment.
This is not desired behaviour. It will break expressions for example.
| private IStringValue<?> stringValue; | ||
| private Function<String, String> validator = val -> val; | ||
| private boolean numbers = false; | ||
| private boolean isNumber = false; |
Author
There was a problem hiding this comment.
because the name for a boolean is not explicit in my opinion. But i rollback if you want.
Collaborator
There was a problem hiding this comment.
Yeah, roll this back. It just makes backporting commits harder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix an excption occurd when TextFieldWidget is initilized like this :
new TextFieldWidget().setFormatAsInteger(true).width(width).height(12);In this cas, if user enter a non-numeric char in the filed, InvalidNumberException thrown.
Improve QOL when a field is numric, remove all non numeric chars onRemoveFocus instead set 0.