Remove unused contents#23
Merged
serenibyss merged 2 commits intoGTNewHorizons:masterfrom May 25, 2025
Merged
Conversation
boubou19
previously requested changes
May 24, 2025
Member
boubou19
left a comment
There was a problem hiding this comment.
Overall if the classes are never used elsewhere, it's more than fine to yeet them, so we reduce cluttering on the codebase
serenibyss
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChannelRegistry is only used by TileTransceiver and ItemWirelessLocationChip.
The original author commented out Transceiver&WirelessLocationChip registration code before GTNH fork.
see:
097a30f#diff-86d17ec053e224d336db41fed952c4d702b993909b8126710704a3f020a98939
RemoteIO/src/main/java/dmillerw/remoteio/lib/ModItems.java
Lines 40 to 45 in 097a30f
RemoteIO/src/main/java/dmillerw/remoteio/lib/ModBlocks.java
Lines 43 to 45 in 097a30f
Now it's still commented out.
Comment in ModItems is removed in current fork.
RemoteIO/src/main/java/remoteio/common/lib/ModBlocks.java
Lines 57 to 61 in 0074636
So I assume that TileTransceiver and ItemWirelessLocationChip are not used.
However ChannelRegistry subscribes events, and try to read/write file, even if there's nothing to save/load.
So this PR remove the subscriptionSo this PR remove all unused contents related to TileTransceiver & WirelessLocationChip.
I created this PR because I got a crash:
crash-2025-05-21_00.56.09-server.txt
Not sure how to reproduct it, but this PR can prevent some potentioal crash.