If an image is taking longer to download than usual, then the "could not extract height/width" error was being displayed. It couldn't be extracted because the image wasn't done downloading yet. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s taking longer than 2 seconds to download
EDIT:Moved my comments about Michael's update and code revisions to a new pull request - the reference is below... |
|
None of above fixes the problem. I am still getting "could not extract width..." error on Chrome (IE and FF works fine). |
anandkkpr
added a commit
to anandkkpr/galleria
that referenced
this pull request
Dec 3, 2011
Quote: "If an image is taking longer to download than usual, then the "could not extract height/width" error was being displayed. It couldn't be extracted because the image wasn't done downloading yet." I've added a comment into that issue's thread and would've wanted to update Michael's code itself but was unable to find out how to do so - I'm a noobie to GitHub... So please forgive me if I'm doing this the wrong way and point me in the right direction if you know how to modify a user-submitted "pull request". I've commented the code as best as I know how and if you wish to see the full reasoning for why I'm submitting this, please visit the original issue: GalleriaJS#213 (comment) Many thanks for your kind patience! Best regards, Anand
This was referenced Dec 3, 2011
|
I just tried 1.2.7a2 and this problem is still not resolved. It seems that any time a max-width property is set, I get these errors. This "flavor" of the issue is the same one that I'm having: |
|
Can you try the patch proposed in #214 with the fix given in the following comment #214 (comment) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 'could not extract height/width of image' issue, if the image is taking longer than 2 seconds to download