Conversation
Adjust the breakpoint for mobile device detection from 768px to 1024px
The color style of the three header icons has been standardized
In dark mode, the "Outline" text is visible now
Fix dark mode outline and theme residual styles by adding destroyOnClose to Drawer to prevent style residuals and setting explicit background colors for Drawer in both themes
Moved the mobile menu styles to NoteLayout.css
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving mobile responsiveness and theme-aware styling by scoping mobile menu CSS to the note layout, refining header icon styling, and adding theme hooks for dark-mode CSS selectors.
Changes:
- Move global mobile menu touch-target styles from
index.cssintoNoteLayout.cssand scope them to the note layout menu. - Update header icon classes/styles to use a shared clickable icon pattern.
- Adjust mobile detection breakpoint and set a
data-themeattribute for CSS-driven dark theme overrides; tweak mobile outline drawer behavior/styling.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.css | Removes previously-global mobile menu overrides. |
| src/common/layouts/NoteLayout.css | Adds scoped mobile menu touch-target overrides under .note-layout__menu. |
| src/common/components/NoteHeader.jsx | Switches search icon to shared clickable icon class pattern. |
| src/common/components/NoteHeader.css | Removes old search-icon-specific rules; relies on shared icon/clickable styles. |
| src/common/components/FloatingOutlineButton.jsx | Ensures drawer unmounts content on close. |
| src/common/components/FloatingOutlineButton.css | Adds drawer background styling + dark theme overrides via data-theme. |
| src/App.jsx | Changes JS mobile breakpoint and sets data-theme on the document element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Centralizing the mobile breakpoint as constant MOBILE_BREAKPOINT = 1024
Align mobile breakpoint across CSS and JS to prevent layout flicker at 768-1023px
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.