Skip to content

feat: support async view functions #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: support async view functions #28

merged 2 commits into from
Nov 16, 2023

Conversation

summersz
Copy link
Contributor

@summersz summersz commented Nov 1, 2023

closes #22

@Ge0rg3
Copy link
Owner

Ge0rg3 commented Nov 16, 2023

Thanks again @summersz, it looks like there was a typo in the PR where asyncio.iscoroutinefunction was instead asyncio.iscoroutinefunctions, but I've gone ahead and fixed that.

I've also added your contributions to the README, they were very valuable and much appreciated 😊🙏

@Ge0rg3 Ge0rg3 merged commit f64236d into Ge0rg3:master Nov 16, 2023
@summersz
Copy link
Contributor Author

Thanks @Ge0rg3 . Good spot! I ended up making these changes in codespaces to avoid logging out of my corporate gh account, so it must have come from some poor copy and pasting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support async routes
2 participants