Skip to content

feat(silo): set timeouts if the connection hangs #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anna-parker wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(silo): set timeouts if the connection hangs #1011

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2d4596
feat(silo): set timeouts if the connection hangs
anna-parker Oct 2, 2025
47ba4de
Merge branch 'main' into timeouts
anna-parker Oct 3, 2025
e87e32d
feat(silo): format
anna-parker Oct 6, 2025
1f44dff
feat(silo): fix
anna-parker Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/silo/api/api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ int Api::runApi(const silo::config::RuntimeConfig& runtime_config) {
try {
server_socket.bind(address, true);
server_socket.listen();
// Set timeouts to avoid hanging connections
server_socket.setReceiveTimeout(Poco::Timespan(30, 0));
Copy link
Contributor Author

@anna-parker anna-parker Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly I just tested locally and these two lines alone do not close the open requests from LAPIS. Potentially we need to set params->setKeepAlive(false);

Copy link
Contributor Author

@anna-parker anna-parker Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! I'm just testing locally and even with setKeepAlive(false) the connections don't appear to be cancelled?

I still see errors when I try to use a new processed data image:

[2025-10-07 09:57:17.812] [logger] [info] [active_database.cpp:23] Some requests on the old database with version 1759822253 are still running. Current reference count: 9
[2025-10-07 09:57:22.818] [logger] [info] [active_database.cpp:23] Some requests on the old database with version 1759822253 are still running. Current reference count: 9

Copy link
Contributor Author

@anna-parker anna-parker Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again as soon as LAPIS is closed these requests go away and the new database can be loaded....

Copy link
Contributor Author

@anna-parker anna-parker Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poco_parameter->setTimeout(Poco::Timespan(300, 0)); also doesn't seem to solve the problem...

server_socket.setSendTimeout(Poco::Timespan(120, 0));
} catch (const Poco::Net::NetException& e) {
SPDLOG_ERROR(
"Failed to bind to port {}: {}", runtime_config.api_options.port, e.displayText()
Expand Down