pygmt.grdfill: Migrate the hole parameter to the new alias system and add a test #4108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
pygmt/tests/test_grdfill.py
Outdated
|
|
||
| def test_grdfill_hole(grid, expected_grid): | ||
| """ | ||
| Test grdfill with different hole values. |
There was a problem hiding this comment.
Hm. I am not sure if I understand what you mean with "different" here. As far as I know, there could be only one value used to define the nodes considered as holes at a time. Maybe "different" refers to the fact that the value for nodes considered as holes is set to a new value in this test?
There was a problem hiding this comment.
I've rephrased it to "Test grdfill with a custom value (not NaN) as holes."
Co-authored-by: Yvonne Fröhlich <[email protected]>
seisman
commented
Sep 21, 2025
yvonnefroehlich
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the 'hole' parameter and add a test to ensure that both
holeandno_data(deprecated) work as expected.