[MISC] Some Bug Fixes for Mesh Related Issues#1800
Merged
Conversation
duburcqa
reviewed
Oct 3, 2025
duburcqa
requested changes
Oct 3, 2025
Collaborator
duburcqa
left a comment
duburcqa
left a comment
There was a problem hiding this comment.
Add unit tests (that are failing before your PR and passing after). You can modify / extend an existing unit test if you want.
Collaborator
|
Hum… we do not test the RayTracer for now… no need to right unit tests for this specific part. |
YilingQiao
previously approved these changes
Oct 4, 2025
Collaborator
Author
|
Added unittest for the other parts. "EXR path" and "Raytracer" should wait for the Luisa unittest. |
duburcqa
previously approved these changes
Oct 5, 2025
duburcqa
approved these changes
Oct 5, 2025
jmCabrillana
pushed a commit
to jmCabrillana/Genesis
that referenced
this pull request
Dec 9, 2025
* Fixes EXR path return. * Update `tex_offset` to `int64`. * Fixes bug that using `Raytracer` and `Rasterizer` simultaneously to render will cause error. * Update shader parsing for USD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tex_offsettoint64.RaytracerandRasterizersimultaneously to render will cause error.