Skip to content

[MISC] Update tex_offset to int64 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duburcqa merged 1 commit into from
Oct 4, 2025
Merged

[MISC] Update tex_offset to int64 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bridge/bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ NB_MODULE(_gs_madrona_batch_renderer, m) {
nb::device::cpu> mat_tex_ids,
nb::ndarray<const uint8_t, nb::shape<-1>,
nb::device::cpu> tex_data,
nb::ndarray<const int32_t, nb::shape<-1>,
nb::ndarray<const int64_t, nb::shape<-1>,
nb::device::cpu> tex_offsets,
nb::ndarray<const int32_t, nb::shape<-1>,
nb::device::cpu> tex_widths,
Expand Down Expand Up @@ -117,7 +117,7 @@ NB_MODULE(_gs_madrona_batch_renderer, m) {
.matRGBA = (math::Vector4 *)mat_rgba.data(),
.matTexIDs = (int32_t *)mat_tex_ids.data(),
.texData = (uint8_t *) tex_data.data(),
.texOffsets = (int32_t *)tex_offsets.data(),
.texOffsets = (int64_t *)tex_offsets.data(),
.texWidths = (int32_t *)tex_widths.data(),
.texHeights = (int32_t *)tex_heights.data(),
.texNChans = (int32_t *)tex_nchans.data(),
Expand Down
2 changes: 1 addition & 1 deletion src/bridge/mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ static RTAssets loadRenderObjects(
SourceTexture *out_textures = tmp_alloc.allocN<SourceTexture>(model.numTextures);

for (CountT i = 0; i < model.numTextures; i++) {
uint32_t tex_offset = model.texOffsets[i];
uint64_t tex_offset = model.texOffsets[i];
Optional<SourceTexture> tex = SourceTexture {
.data = &model.texData[tex_offset],
.format = SourceTextureFormat::R8G8B8A8,
Expand Down
2 changes: 1 addition & 1 deletion src/bridge/mgr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ struct GSModel {
madrona::math::Vector4 *matRGBA;
int32_t *matTexIDs;
uint8_t *texData;
int32_t *texOffsets;
int64_t *texOffsets;
int32_t *texWidths;
int32_t *texHeights;
int32_t *texNChans;
Expand Down