Skip to content

Comments

Fix readiness declared/actual drift guard for dataset-based reports#757

Open
GenesisAeon wants to merge 1 commit intomainfrom
codex/improve-documentation-consistency-and-status-tracking-0c4mgc
Open

Fix readiness declared/actual drift guard for dataset-based reports#757
GenesisAeon wants to merge 1 commit intomainfrom
codex/improve-documentation-consistency-and-status-tracking-0c4mgc

Conversation

@GenesisAeon
Copy link
Owner

Motivation

  • The readiness drift validator only inspected a legacy domains shape and therefore missed declared-vs-actual mismatches in the current datasets[].components[] report schema, allowing status drift to go undetected.
  • Backwards compatibility and clearer diagnostics are required so both new and legacy report shapes are validated reliably.

Description

  • Update scripts/validation/check_readiness_declared_actual.py to collect mismatches from both datasets and domains, using a local collect helper that normalizes domain/dataset identifiers and emits mismatches with scope, dataset, and domain fields.
  • Improve mismatch logging by updating _print_report to include the scope and dataset context in printed lines.
  • Add focused regression tests in tests/test_readiness_declared_actual_guard.py that assert detection for the datasets-shaped report and preserve legacy domains-shaped behavior.
  • No readiness report artifacts or UI files were modified.

Testing

  • Ran pytest -q tests/test_readiness_declared_actual_guard.py, which passed (2 tests).
  • Executed python3 scripts/validation/check_readiness_declared_actual.py, which printed parity status and exited successfully.
  • Executed python3 analysis/v2_readiness_audit.py --fail-on-declared-drift, which completed without error (no declared/actual drift triggered).

Codex Task

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant