Fix readiness declared/actual drift guard for dataset-based reports#757
Open
GenesisAeon wants to merge 1 commit intomainfrom
Open
Fix readiness declared/actual drift guard for dataset-based reports#757GenesisAeon wants to merge 1 commit intomainfrom
GenesisAeon wants to merge 1 commit intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
domainsshape and therefore missed declared-vs-actual mismatches in the currentdatasets[].components[]report schema, allowing status drift to go undetected.Description
scripts/validation/check_readiness_declared_actual.pyto collect mismatches from bothdatasetsanddomains, using a localcollecthelper that normalizesdomain/datasetidentifiers and emits mismatches withscope,dataset, anddomainfields._print_reportto include thescopeanddatasetcontext in printed lines.tests/test_readiness_declared_actual_guard.pythat assert detection for thedatasets-shaped report and preserve legacydomains-shaped behavior.Testing
pytest -q tests/test_readiness_declared_actual_guard.py, which passed (2 tests).python3 scripts/validation/check_readiness_declared_actual.py, which printed parity status and exited successfully.python3 analysis/v2_readiness_audit.py --fail-on-declared-drift, which completed without error (no declared/actual drift triggered).Codex Task