feat(store): replace FTS5 default ranking with weighted BM25#526
Open
daniel-baf wants to merge 1 commit into
Open
feat(store): replace FTS5 default ranking with weighted BM25#526daniel-baf wants to merge 1 commit into
daniel-baf wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesWeighted BM25 FTS5 Ranking
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241
PR Type
type:bug— Bug fixtype:feature— New featuretype:docs— Documentation onlytype:refactor— Code refactoring (no behavior change)type:chore— Maintenance, dependencies, toolingtype:breaking-change— Breaking changeSummary
fts.rank) inStore.Searchquery with a weighted BM25 query:bm25(observations_fts, 5.0, 1.0, 0.0, 0.0, 0.0, 3.0).title(5.0 weight) andtopic_key(3.0 weight) over lower-relevance columns liketool_nameortype.Changes
internal/store/store.gofts.rankwithbm25(...)query and updateORDER BYclauseinternal/store/store_test.goTestSearch_WeightedBM25Rankingunit testTest Plan
go test ./...go test -tags e2e ./internal/server/...Contributor Checklist
Closes #241)type:*label to this PRCo-Authored-Bytrailers in commitsSummary by CodeRabbit