Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAYER-49] refacto disk io #120

Merged
merged 6 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/assets/images/ic_check.svg
pgivel marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 0 additions & 7 deletions src/assets/images/ic_close-modal.svg

This file was deleted.

3 changes: 3 additions & 0 deletions src/assets/images/ic_close.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 1 addition & 4 deletions src/plugins/Battery.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ module.exports = class Battery extends OverlayPlugin {
*/
renderWidget() {
// Create elements

const {modal, container} = this.createTemplateModal({
title: this.i18n.BATTERY_TITLE || 'Battery',
classes: 'gm-battery-plugin',
Expand Down Expand Up @@ -184,7 +183,6 @@ module.exports = class Battery extends OverlayPlugin {
this.chargeGroup.appendChild(sliderGroup);

// Charge level input
const inputGroup = document.createElement('div');
this.chargeInput = textInput.createTextInput({
appendText: '%',
value: '50',
Expand All @@ -198,8 +196,7 @@ module.exports = class Battery extends OverlayPlugin {

this.chargeInput.element.className = 'gm-charge-input';

inputGroup.appendChild(this.chargeInput.element);
this.chargeGroup.appendChild(inputGroup);
this.chargeGroup.appendChild(this.chargeInput.element);

return this.chargeGroup;
}
Expand Down
Loading
Loading