Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAYER-42] customize toolbar order #123

Open
wants to merge 8 commits into
base: dev/player-48-rework-clipboard
Choose a base branch
from

Conversation

jparez
Copy link
Contributor

@jparez jparez commented Jan 22, 2025

Description

This PR adds the feature for ordered icons in the toolbar and displays separators.

image

A new option (toolbarOrder), which is an array, has been added to the options passed to the constructor of the player.
The IDs to include in the array correspond to the constructor name registered in the plugin.

static get name() {
    return 'StreamResolution';
}

For ButtonsEvents, the name is formed like this: ButtonsEvents_XXX, where XXX can be one of the following:
ROTATE, VOLUME_DOWN, VOLUME_UP, HOMEPAGE, BACK, or POWER.

These 3 commits are independent of this story:

@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch from 61cd442 to 122e48a Compare January 22, 2025 12:59
@jparez jparez changed the base branch from main to dev/player-48-rework-clipboard January 22, 2025 12:59
@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch 2 times, most recently from 1fa6b1a to 1d631bd Compare January 22, 2025 15:43
@jparez jparez requested review from pgivel and caarmen January 22, 2025 16:13
@jparez jparez marked this pull request as draft January 22, 2025 16:16
Copy link
Contributor

@pgivel pgivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions but honestly this looks great. It adds a feature while making everything look cleaner in the code, I love it.

src/plugins/Fullscreen.js Show resolved Hide resolved
src/plugins/util/ToolBarManager.js Show resolved Hide resolved
src/scss/components/_screencast.scss Show resolved Hide resolved
src/plugins/util/ToolBarManager.js Show resolved Hide resolved
src/plugins/Camera.js Outdated Show resolved Hide resolved
src/DeviceRendererFactory.js Outdated Show resolved Hide resolved
@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch from ca27381 to a725bbe Compare January 23, 2025 10:07
README.md Show resolved Hide resolved
@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch 2 times, most recently from 64fe8c3 to 2d7d376 Compare January 23, 2025 12:37
@jparez jparez marked this pull request as ready for review January 23, 2025 14:33
@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch 2 times, most recently from 913f2ff to c4db4a2 Compare January 23, 2025 15:07
Copy link
Contributor

@caarmen caarmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the README :)

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch 5 times, most recently from 18567dd to 3c60fc1 Compare January 23, 2025 17:02
@jparez jparez force-pushed the dev/player-48-rework-clipboard branch from 3d1a088 to 32f8701 Compare January 27, 2025 13:12
@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch 2 times, most recently from 704d301 to 5827456 Compare January 27, 2025 13:57
Copy link
Contributor

@caarmen caarmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked out the README. Looks good!

@jparez jparez force-pushed the dev/player-42-customize-toolbar-order branch from 5827456 to c01d918 Compare January 28, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants