-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAYER-42] customize toolbar order #123
base: dev/player-48-rework-clipboard
Are you sure you want to change the base?
[PLAYER-42] customize toolbar order #123
Conversation
61cd442
to
122e48a
Compare
1fa6b1a
to
1d631bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions but honestly this looks great. It adds a feature while making everything look cleaner in the code, I love it.
ca27381
to
a725bbe
Compare
64fe8c3
to
2d7d376
Compare
913f2ff
to
c4db4a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed the README :)
18567dd
to
3c60fc1
Compare
3d1a088
to
32f8701
Compare
704d301
to
5827456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked out the README. Looks good!
5827456
to
c01d918
Compare
Description
This PR adds the feature for ordered icons in the toolbar and displays separators.
A new option (
toolbarOrder
), which is an array, has been added to the options passed to the constructor of the player.The IDs to include in the array correspond to the constructor name registered in the plugin.
For
ButtonsEvents
, the name is formed like this:ButtonsEvents_XXX
, where XXX can be one of the following:ROTATE, VOLUME_DOWN, VOLUME_UP, HOMEPAGE, BACK, or POWER.
These 3 commits are independent of this story: