Oceanic plate plate model cooling topography#924
Open
simransuresh wants to merge 5 commits into
Open
Conversation
Contributor
Author
Pull Request Test Coverage Report for Build 23848298487Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
353244b to
f2328b8
Compare
|
alarshi
reviewed
Mar 30, 2026
Contributor
alarshi
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
I have a comment on the reference for the implementation, after you address that, I will be able to review your PR better.
Comment on lines
+185
to
+197
| for (int n = 1; n <= summation_number; ++n) | ||
| { | ||
| const double n2 = double(n) * double(n); | ||
| sum += (1.0 / n2) * | ||
| (1.0 - std::exp(-(n2 * Consts::PI * Consts::PI * kappa * age) / (L * L))); | ||
| } | ||
|
|
||
| double plate_topography = | ||
| min_ocean_depth + (2.0 * bottom_density * alpha * (bottom_temperature - top_temperature) * L | ||
| / (top_density * Consts::PI * Consts::PI)) * sum; | ||
|
|
||
| //return apply_operation(operation, current_topography, -plate_topography); | ||
| return -plate_topography; |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
The second formula has a missing exp so I used first one but didnt add that reference. I have corrected the formula (from Turcotte & Schubert) and committed now.
Contributor
Author
|
@alarshi and @danieldouglas92 I have addressed all your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading. Please reload this page.