Skip to content

Oceanic plate plate model cooling topography#924

Open
simransuresh wants to merge 5 commits into
GeodynamicWorldBuilder:mainfrom
simransuresh:ocean_topo_plate_model
Open

Oceanic plate plate model cooling topography#924
simransuresh wants to merge 5 commits into
GeodynamicWorldBuilder:mainfrom
simransuresh:ocean_topo_plate_model

Conversation

@simransuresh
Copy link
Copy Markdown
Contributor

@simransuresh simransuresh commented Mar 30, 2026

  • for oceanic plate, a plate model cooling topography is added. Similar to the half space cooling model
  • input params are flexible - top density, bottom density, top temperature, bottom temperature and min_ocean_depth is the ridge distance from surface.
  • assumption is L in the equation which is the plate thickness - set to max_depth param.
  • Ref: Turcotte and Schubert geodynamics book

@simransuresh
Copy link
Copy Markdown
Contributor Author

image

Plate model in topography plugin of oceanic plate. ridge center is 100e3 on a total dimension of 1150e3 and plot below shows the line perpendicular across ridge.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 30, 2026

Pull Request Test Coverage Report for Build 23848298487

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 80 of 81 (98.77%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.08%) to 98.469%

Changes Missing Coverage Covered Lines Changed/Added Lines %
source/world_builder/features/oceanic_plate_models/topography/plate_model.cc 80 81 98.77%
Files with Coverage Reduction New Missed Lines %
source/world_builder/features/continental_plate_models/density/uniform.cc 1 97.56%
source/world_builder/features/fault_models/density/uniform.cc 1 96.97%
source/world_builder/features/mantle_layer_models/density/uniform.cc 1 97.56%
source/world_builder/features/oceanic_plate_models/density/uniform.cc 1 97.56%
source/world_builder/features/plume_models/density/uniform.cc 1 96.97%
source/world_builder/features/subducting_plate_models/density/uniform.cc 1 96.97%
source/world_builder/world.cc 5 92.51%
source/world_builder/parameters.cc 20 97.12%
Totals Coverage Status
Change from base Build 23748207793: 0.08%
Covered Lines: 11194
Relevant Lines: 11368

💛 - Coveralls

@simransuresh simransuresh force-pushed the ocean_topo_plate_model branch from 353244b to f2328b8 Compare March 30, 2026 15:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2026

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.311 ± 0.005 (s=342) 1.302 ± 0.005 (s=349) -0.8% .. -0.6%
Slab interpolation curved simple none 1.313 ± 0.007 (s=357) 1.304 ± 0.008 (s=333) -0.8% .. -0.6%
Spherical slab interpolation simple none 1.303 ± 0.013 (s=348) 1.298 ± 0.008 (s=347) -0.6% .. -0.2%
Slab interpolation simple curved CMS 1.212 ± 0.009 (s=380) 1.210 ± 0.007 (s=366) -0.3% .. +0.0%
Spherical slab interpolation simple CMS 1.625 ± 0.008 (s=290) 1.622 ± 0.007 (s=267) -0.3% .. -0.0%
Spherical fault interpolation simple none 1.287 ± 0.007 (s=362) 1.283 ± 0.007 (s=341) -0.5% .. -0.2%
Cartesian min max surface 2.827 ± 0.020 (s=142) 2.827 ± 0.029 (s=179) -0.3% .. +0.3%
Spherical min max surface 8.626 ± 0.086 (s=55) 8.580 ± 0.091 (s=52) -1.2% .. +0.1%

Copy link
Copy Markdown
Contributor

@alarshi alarshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
I have a comment on the reference for the implementation, after you address that, I will be able to review your PR better.

Comment thread include/world_builder/features/oceanic_plate_models/topography/plate_model.h Outdated
Comment thread include/world_builder/features/oceanic_plate_models/topography/plate_model.h Outdated
Comment on lines +185 to +197
for (int n = 1; n <= summation_number; ++n)
{
const double n2 = double(n) * double(n);
sum += (1.0 / n2) *
(1.0 - std::exp(-(n2 * Consts::PI * Consts::PI * kappa * age) / (L * L)));
}

double plate_topography =
min_ocean_depth + (2.0 * bottom_density * alpha * (bottom_temperature - top_temperature) * L
/ (top_density * Consts::PI * Consts::PI)) * sum;

//return apply_operation(operation, current_topography, -plate_topography);
return -plate_topography;
Copy link
Copy Markdown
Contributor

@alarshi alarshi Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you send me the screenshot of the page or the exact reference you are using. I am comparing against Turcotte & Schubert :

Image

and Fowler's reference :

Image

Both of them differ from what you have. I suspect that you have a different version and I am unable to compare your implementation right now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second formula has a missing exp so I used first one but didnt add that reference. I have corrected the formula (from Turcotte & Schubert) and committed now.

@simransuresh
Copy link
Copy Markdown
Contributor Author

@alarshi and @danieldouglas92 I have addressed all your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants