Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions cloudlift/deployment/ecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,15 @@
from datetime import datetime
from json import dumps

from cloudlift.exceptions import UnrecoverableException

from boto3.session import Session
from botocore.exceptions import ClientError, NoCredentialsError
from dateutil.tz.tz import tzlocal

from cloudlift.version import VERSION
from distutils.version import LooseVersion


class EcsClient(object):
def __init__(self, access_key_id=None, secret_access_key=None,
Expand All @@ -37,7 +42,10 @@ def describe_services(self, cluster_name, service_name):
def describe_task_definition(self, task_definition_arn):
try:
return self.boto.describe_task_definition(
taskDefinition=task_definition_arn
taskDefinition=task_definition_arn,
include=[
'TAGS'
]
)
except ClientError:
raise UnknownTaskDefinitionError(
Expand Down Expand Up @@ -73,6 +81,9 @@ def register_task_definition(self, family, containers, volumes, role_arn, cpu=Fa
volumes=volumes,
taskRoleArn=role_arn or u'',
networkMode=network_mode,
tags=[
{'key': 'cloudlift_version', 'value': VERSION},
],
**fargate_td
)

Expand Down Expand Up @@ -414,7 +425,8 @@ def get_task_definition(self, task_definition):
task_definition_arn=task_definition
)
task_definition = EcsTaskDefinition(
task_definition=task_definition_payload[u'taskDefinition']
task_definition=task_definition_payload[u'taskDefinition'],
tags=task_definition_payload[u'tags']
)
return task_definition

Expand All @@ -429,6 +441,8 @@ def update_task_definition(self, task_definition):
'memory' : task_definition.memory or u'',

}
td_tags=task_definition[u'tags']
self.check_tags(td_tags)
response = self._client.register_task_definition(
family=task_definition.family,
containers=task_definition.containers,
Expand All @@ -441,6 +455,21 @@ def update_task_definition(self, task_definition):
self._client.deregister_task_definition(task_definition.arn)
return new_task_definition

def check_tags(self, tags):
if tags:
for tag in tags:
if tag[u'key']=="cloudlift_version":
if LooseVersion(tag[u'value'])>LooseVersion(VERSION):
raise UnrecoverableException(f'Cloudlift Version {tag[u"value"]} was used to '
f'create this task_definition. You are using version {VERSION}, '
f'which is older and can cause corruption. Please upgrade to at least '
f'version {tag[u"value"]} to proceed.\n\nUpgrade to the '
f'latest version (Recommended):\n'
f'\tpip install -U cloudlift\n\nOR\n\nUpgrade to a compatible version:\n'
f'\tpip install -U cloudlift=={tag[u"value"]}')
else:
return

def update_service(self, service):
response = self._client.update_service(
cluster=service.cluster,
Expand Down