Skip to content

added support for multiple mfa #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
praveenraghav01 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added support for multiple mfa #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions cloudlift/config/mfa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,16 @@
from boto3 import client
from boto3.session import Session
from cloudlift.exceptions import UnrecoverableException

from click import prompt
from cloudlift.config import get_account_id
from cloudlift.config.logging import log_bold, log_err
from cloudlift.config.logging import log_bold, log_err, log


def do_mfa_login(mfa_code=None, region='ap-south-1'):
username = get_username()
mfa_arn = get_mfa_arn(username)
if not mfa_code:
mfa_code = input("MFA Code: ")
mfa_arn = "arn:aws:iam::%s:mfa/%s" % (get_account_id(), username)

log_bold("Using credentials for " + username)
try:
session_params = client('sts').get_session_token(
Expand All @@ -34,10 +33,9 @@ def do_mfa_login(mfa_code=None, region='ap-south-1'):

def get_mfa_session(mfa_code=None, region='ap-south-1'):
username = get_username()
mfa_arn = get_mfa_arn(username)
if not mfa_code:
mfa_code = input("MFA Code: ")
mfa_arn = "arn:aws:iam::%s:mfa/%s" % (get_account_id(), username)

log_bold("Using credentials for " + username)
try:
session_params = client('sts').get_session_token(
Expand All @@ -58,3 +56,17 @@ def get_mfa_session(mfa_code=None, region='ap-south-1'):

def get_username():
return client('sts').get_caller_identity()['Arn'].split("user/")[1]

def get_mfa_arn(username):
try:
response = client('iam').list_mfa_devices(UserName=username)
if len(response['MFADevices']) == 1:
return response['MFADevices'][0]['SerialNumber']
elif len(response['MFADevices']) > 1:
log_bold("More than one MFA device found \nPlease enter the serial number of the MFA device you want to use")
for index, device in enumerate(response['MFADevices']):
log(str(index) + ". " + device["SerialNumber"].split("/")[1])
n = prompt("serial number", default=0)
return response['MFADevices'][n]['SerialNumber']
except botocore.exceptions.ClientError as client_error:
raise UnrecoverableException(str(client_error))
2 changes: 0 additions & 2 deletions cloudlift/session/session_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ def __init__(self, name, environment):
def start_session(self, mfa_code, component):
user_id = (self.sts_client.get_caller_identity()['Arn'].split("/")[0]).split(":")[-1]
if user_id == "user":
if mfa_code == None:
mfa_code = prompt("MFA code")
mfa.do_mfa_login(mfa_code, get_region_for_environment(self.environment))
target_instance = self._get_target_instance(component)
elif user_id == "assumed-role":
Expand Down