Added explicit environment to role #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure clarity when looking for the roles in AWS. While cloudformation would prefix the environment, it would get truncated, if the service name were too long. Also bumped the boto3 version to ensure that some of the new capabilities such as ECR image scanning work on all deployments.
jeechu
pushed a commit
to jeechu/cloudlift
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure clarity when looking for the roles in AWS. While
cloudformation would prefix the environment, it would get truncated,
if the service name were too long.
Also bumped the boto3 version to ensure that some of the new
capabilities such as ECR image scanning work on all deployments.