Skip to content

Update/adding global exception handlers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kamalnrf wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update/adding global exception handlers #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba02508
Added exception handler in android
Mar 28, 2019
9021e08
Added exception handlers for IOS part
Apr 1, 2019
8109bf0
fix
Apr 11, 2019
3412a3c
android fix
Apr 11, 2019
77eded2
fix for calling callback with wrong parameters
Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions android/src/main/java/com/android/simpl/fingerprint/SimplFingerprintSdkModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@ public String getName() {

@ReactMethod
public void generateFingerprint(final String clientId, final String phoneNumber, final String emailId, final Callback callback) {
SimplFingerprint.init(getReactApplicationContext(), phoneNumber, emailId);
SimplFingerprint.getInstance().generateFingerprint(new SimplFingerprintListener() {
@Override
public void fingerprintData(String fingerprint) {
callback.invoke(fingerprint);
}
});
try {
SimplFingerprint.init(getReactApplicationContext(), phoneNumber, emailId);
SimplFingerprint.getInstance().generateFingerprint(new SimplFingerprintListener() {
@Override
public void fingerprintData(String fingerprint) {
callback.invoke(fingerprint);
}
});
}catch (Exception ex){
callback.invoke(ex.getMessage());
}
}

}
17 changes: 11 additions & 6 deletions ios/SimplFingerPrint/Simpl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,17 @@ @implementation Simpl

RCT_EXPORT_MODULE()

RCT_EXPORT_METHOD(generateFingerprint:(NSString *)clientId phoneNumber:(NSString *) phoneNumber email: (NSString *) email callback:(RCTResponseSenderBlock)callback) {
GSUser *user = [[GSUser alloc] initWithPhoneNumber: phoneNumber email: email];
GSFingerPrint *fingerprint = [[GSFingerPrint alloc] initWithMerchantId:clientId andUser:user];
[fingerprint generateEncryptedPayloadWithCallback:^(NSString *payload) {
callback(@[payload]);
}];
RCT_EXPORT_METHOD(generateFingerprint:(NSString *)clientId phoneNumber:(NSString *)phoneNumber email: (NSString *)email callback:(RCTResponseSenderBlock)callback) {
@try {
GSUser *user = [[GSUser alloc] initWithPhoneNumber: phoneNumber email: email];
GSFingerPrint *fingerprint = [[GSFingerPrint alloc] initWithMerchantId:clientId andUser:user];
[fingerprint generateEncryptedPayloadWithCallback:^(NSString *payload) {
callback(@[payload]);
}];
}
@catch (NSException * ex){
callback(@[[ex reason]]);
}
}

- (dispatch_queue_t)methodQueue
Expand Down