Skip to content

[AND-520] Clean-up sample users. #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 27, 2025
Merged

[AND-520] Clean-up sample users. #5765

merged 12 commits into from
May 27, 2025

Conversation

VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented May 7, 2025 •
edited
Loading

🎯 Goal

  • Move current employees to the top of the sample users list
  • Replace former employee names and images with sample ones (StarWars characters - similar to the iOS sample)
  • Remove QATest users
  • Note: IDs are kept as previous, so that we persist the sample users chat history.
  • Additionally replaces the usernames and images for test and previews data

Important

Once this is merged, please update your branch and make sure to not log in with the 'old' users, so the username/image are not overridden.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.16 MB 3.16 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.91 MB 7.91 MB 0.00 MB 🟢
stream-chat-android-compose 12.41 MB 12.41 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review May 7, 2025 15:09
@VelikovPetar VelikovPetar requested a review from a team as a code owner May 7, 2025 15:09
PetarVelikov and others added 4 commits May 27, 2025 09:59
Merge branch 'develop' into feature/cleanup-sample-users
49e3ea3 
# Conflicts:
#	stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channels_ChannelListTest_loaded_channels.png
#	stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channels_ChannelListTest_loading_more_channels.png
#	stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channels_ChannelListTest_search_results.png
#	stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channels_ChannelsTest_loaded_channels.png
Update snapshots.
ef08202
@andremion
Merge branch 'develop' into feature/cleanup-sample-users
d56d3ec
@andremion
Merge branch 'develop' into feature/cleanup-sample-users
432ba31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
63.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@andremion andremion merged commit a0a310e into develop May 27, 2025
12 of 13 checks passed
@andremion andremion deleted the feature/cleanup-sample-users branch May 27, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andremion andremion andremion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VelikovPetar @andremion