Skip to content

Conversation

@nijeesh-stream
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Fix Sorbet type checking issue in Ruby 3.4 by adding missing RBI definition for Prism::LexCompat::Result [ it will skip the sorbet type check for this package ]

Tested against Ruby 3.0, 3.1, and 3.4 - all passing type checks now.
https://github.com/GetStream/stream-chat-ruby/actions/runs/14107089578/job/39516030327

@nijeesh-stream nijeesh-stream changed the title [] Added Prism from sorbet todo [] Added Prism TO sorbet todo Mar 27, 2025
@nijeesh-stream nijeesh-stream merged commit 18981d0 into master Mar 27, 2025
4 checks passed
@nijeesh-stream nijeesh-stream deleted the fix/ci-fail-ruby-3.4-type_check branch March 27, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants