Swift 6: complete concurrency checking (LLC and UIKit) #3661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/StreamChat/WebSocketClient/BackgroundTaskScheduler.swift
# Conflicts: # Sources/StreamChat/Models/CurrentUser.swift # Sources/StreamChat/Workers/CurrentUserUpdater.swift
laevandus
added
the
🌐 SDK: StreamChat (LLC)
Generated by 🚫 Danger |
laevandus
commented
May 5, 2025
Comment on lines
-71
to
+72
| if: ${{ github.event.inputs.record_snapshots != 'true' }} | ||
| # if: ${{ github.event.inputs.record_snapshots != 'true' }} | ||
| if: false # disable Xcode 15 builds |
There was a problem hiding this comment.
Disabled Xcode 15 builds (it is hard to support it when complete concurrency checking is enabled). Hard means avoiding compiler crashes.
SDK Size
|
laevandus
commented
May 5, 2025
| @@ -26,7 +26,7 @@ final class StreamAudioWaveformAnalyser: AudioAnalysing { | |||
| private let audioSamplesExtractor: AudioSamplesExtractor | |||
| private let audioSamplesProcessor: AudioSamplesProcessor | |||
| private let audioSamplesPercentageNormaliser: AudioValuePercentageNormaliser | |||
| private let outputSettings: [String: Any] | |||
| nonisolated(unsafe) private let outputSettings: [String: Any] | |||
There was a problem hiding this comment.
nonisolated(unsafe) because value is Any
SDK Performance
|
laevandus
commented
May 5, 2025
|
|
||
| import Foundation | ||
|
|
||
| /// Erase type for structs which recursively contain themselves. |
There was a problem hiding this comment.
It is easier to use a type instead of a closure when dealing with Sendable.
laevandus
commented
May 5, 2025
| @@ -131,15 +131,19 @@ open class StreamAudioPlayer: AudioPlaying, AppStateObserverDelegate { | |||
| open func play() { | |||
| do { | |||
| try audioSessionConfigurator.activatePlaybackSession() | |||
| player.play() | |||
| MainActor.ensureIsolated { | |||
| player.play() | |||
There was a problem hiding this comment.
Note that AVPlayer and some asset related methods require main actor
laevandus
commented
May 5, 2025
|
|
||
| // MARK: - | ||
|
|
||
| private static let queue = DispatchQueue(label: "io.getstream.stream-runtime-check", target: .global()) |
There was a problem hiding this comment.
Alternative is to skip using queue here and making everything nonisolated(unsafe), especially because these are internal runtime checkes.
laevandus
changed the title
6 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
StreamChatUI changes are in #3660 and will be merged to here. This PR can be reviewed already.
🔗 Issue Links
Resolves IOS-735
🎯 Goal
📝 Summary
Sendableconformance to types@Sendableto completion handlers@unchecked Sendabletypes (internal classes have manual handling and found many which did not guard that state properly)@Sendableto completion handlers creates warnings at callsites)🛠 Implementation
🧪 Manual Testing Notes
Manual regression testing round when UIKit changes are merged into this branch.
☑️ Contributor Checklist
docs-contentrepo