Added support for Forge Config API Port and Sit! mods.#86
Open
PlixyMC wants to merge 53 commits into
Open
Conversation
Co-authored-by: Eclipse <eclipse@eclipseisoffline.xyz>
P.S: also updated vscode settings
…n MetadataPackModule
Removed following folders: .vscode and crash-logs.
This reverts commit eaf8b16.
Added forgeconfigapiport to ingored mods
Added a note about crash fixes with ForgeConfigAPI in the Hydraulic mod description.
…build" This reverts commit f05dd60.
This reverts commit 667c26e.
Add changes from upstream into ForgeConfigAPI compatible fork.
Removed redundant information about the crash fix with ForgeConfigAPI to stay consistent with upstream.
Contributor
|
This looks good to me. I would remove the defaultTasks line and update the README.md file to match Hydraulic pull request #85. |
… match pull request GeyserMC#85.
Contributor
|
Probably a good idea to revert the weird two blank space lines in that file you removed the default task line in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on Commit e8ebe90 which added Minecraft 26.1 support. This PR adds support for Forge Config API Port mod and the Sit! mod.
latest.log
In my server log, you can see the Sit! mod, ForgeConfigApiPort mod working with this PR of Hydraulic.
This PR will resolve issue #57 and issue #50.