Support mapping items directly overriding vanilla item model definitions using modern CMD (#14)#24
Merged
eclipseisoffline merged 2 commits intoGeyserMC:masterfrom Apr 19, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #14 by introducing support for mapping items that directly override a vanilla item model definition to Rainbow.
This is done by adding an
ignoreTopPlainModelproperty toBedrockItemMapper, which results in ignoring the vanilla plain model case, so that vanilla models are ignored, and making the necessary changes inBedrockPack#mapto aid for this. Legacy custom model data mappings are now only used when an item is using a vanillaminecraft:item_model, and has aminecraft:custom_model_datawith a single float, and a single float only (no flags, strings or colours).Also fixes #4, range dispatch model entries are now sorted before the custom model data value is looked up in the array of thresholds, which matches vanilla behaviour.