Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to enhance Java debugging queries by adding the CodeQL Java extensions.
- Added a dependency for githubsecuritylab/codeql-java-extensions at version 0.2.1 in the qlpack configuration file.
Files not reviewed (7)
- java/lib/ghsl.qll: Language not supported
- java/lib/ghsl/Utils.qll: Language not supported
- java/src/debugging/PartialPathsFromSink.ql: Language not supported
- java/src/debugging/PartialPathsFromSource.ql: Language not supported
- java/src/debugging/Sinks.ql: Language not supported
- java/src/debugging/Sources.ql: Language not supported
- java/src/suites/java-debugging.qls: Language not supported
felickz
approved these changes
Apr 15, 2025
Contributor
felickz
left a comment
felickz
left a comment
There was a problem hiding this comment.
Super helpful to have the fromSource / fromSink exploration!
Like the idea of a /debug/ folder/suite!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding various utility predicates and classes for the Java library, this PR enhances the debugging capabilities by introducing new queries for partial paths from sources and sinks.
Enhancements to utility predicates and classes:
java/lib/ghsl.qll: Added imports forghsl.LocalSourcesandghsl.Utils.java/lib/ghsl/Utils.qll: Introduced utility predicates and classes, such asfindByLocation,isCallable,checkSource,LocalSources,AllSources, andAllSinks.Debugging improvements:
java/src/debugging/PartialPathsFromSink.ql: Added a new query for partial paths from sinks, including configuration and partial flow exploration.java/src/debugging/PartialPathsFromSource.ql: Added a new query for partial paths from sources, including configuration and partial flow exploration.java/src/debugging/Sinks.ql: Added a query to list all known sinks.java/src/debugging/Sources.ql: Added a query to list all known sources, including remote and local sources.Dependency updates:
java/lib/qlpack.yml: Updated to includegithubsecuritylab/codeql-java-extensionsas a dependency.Configuration updates:
java/src/suites/java-debugging.qls: Added a new suite description and included queries with specific tags and precision levels for debugging.