Skip to content

Conversation

kevinbackhouse
Copy link
Collaborator

The main change is in yaml_parser.py where I've removed the optional recurse and dir_namespace parameters. It now always recurses and always creates a namespaced name. For example, it will now generate the name personalities/examples/apple_expert.yaml rather than just apple_expert. These names are all relative to a root directory that contains all of the yaml files, which means that the names are never ambiguous.

In a future PR, I would like to add support for relative names like ../personalities/kev.yaml.

@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 16:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@m-y-mo
Copy link
Contributor

m-y-mo commented Oct 14, 2025

Could you also change the README to reflect this change? Thanks. (I think from here onwards: https://github.com/GitHubSecurityLab/seclab-taskflow-agent?tab=readme-ov-file#personalities)

@kevinbackhouse
Copy link
Collaborator Author

This is now updated to use "filekeys" for cross-referencing.

@m-y-mo
Copy link
Contributor

m-y-mo commented Oct 17, 2025

Can we drop the .yaml extension in filekeys because everything is yaml so it doesn't really add anything other than more typing? Also the echo toolbox doesn't seem to have the .yaml extension in the filekeys. Also can we use dots instead of slash for namespacing, e.g. personalities/action_expert.yaml -> personalities.action_expert so it is clear that we are using filekeys and not filepath for referencing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants