Added TvOS, MacOS, iOSX64 support #770
Conversation
Updated the build configuration to include support for tvOS by setting deployment targets and adjusting Kotlin opt-ins. Also, updated Gradle and library versions to their latest stable releases as of commit `9b4c5f6`. This change ensures compatibility with new platforms while leveraging the latest features and improvements in dependencies.
Updated the build configuration to include support for macOS by setting appropriate deployment targets. Enhanced platform coverage by adding macOS targets to existing iOS, tvOS, and Kotlin opt-ins. Updated Gradle and library versions to their latest stable releases, ensuring compatibility with new platforms while leveraging recent improvements in dependencies.
|
Please come back with the iosX64 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for TvOS, MacOS, and iOSX64 platforms to the Firebase Kotlin SDK by extending the build configurations across all Firebase modules and updating the CI/CD pipeline to test these new platforms.
Key changes:
- Expanded Apple platform support from iOS-only to include TvOS, MacOS, and iOSX64
- Updated build configurations to support the new Apple platforms with appropriate deployment targets
- Added comprehensive test skipping configurations for the new platforms
Reviewed Changes
Copilot reviewed 24 out of 72 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Added test skip configuration properties for MacOS and TvOS platforms |
| gradle/libs.versions.toml | Added deployment target versions for TvOS (13.0) and MacOS (10.15) |
| Multiple build.gradle.kts files | Extended Kotlin multiplatform configurations to include new Apple targets and deployment settings |
| GitHub workflow files | Updated CI/CD pipelines to test MacOS and TvOS platforms with specific Xcode version |
| Test utility files | Minor import optimizations and platform detection logic updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…supported targets for Firebase Crashlytics
|
@nbransby - want to review this? |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 26 out of 74 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| minSdk = | ||
| 23 // Auth has a MinSDK of 23. See https://github.com/firebase/firebase-android-sdk/issues/5927#issuecomment-2093466572 |
There was a problem hiding this comment.
[nitpick] The line break in the minSdk assignment makes the code less readable. Consider keeping the assignment on a single line or properly aligning the continuation.
| minSdk = | |
| 23 // Auth has a MinSDK of 23. See https://github.com/firebase/firebase-android-sdk/issues/5927#issuecomment-2093466572 | |
| minSdk = 23 // Auth has a MinSDK of 23. See https://github.com/firebase/firebase-android-sdk/issues/5927#issuecomment-2093466572 |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 26 out of 74 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 26 out of 74 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
firebase-auth/build.gradle.kts
Outdated
| iosArm64().enableKeychainForTests() | ||
| iosX64().enableKeychainForTests() |
There was a problem hiding this comment.
[nitpick] The enableKeychainForTests() method calls are duplicated across multiple Apple platform targets. Consider extracting this into a helper function to reduce code duplication.
Copilot uses AI. Check for mistakes.
5 participants
This is taken from #729
Thank you for your contributions @sajidalidev
I have rebased and re-added iosX64.