Skip to content

Format the commitMsg so it doesn't break PlantUml #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

9swampy
Copy link
Contributor

@9swampy 9swampy commented Jun 23, 2025

Description

Test scenarios that generate UML output break PlantUml when the commit msg doesn't play nice.

Related Issue

#4585

Motivation and Context

I want to be able to copy paste from the scenario output without having to tidy upthe output.

How Has This Been Tested?

Refer to screenshot following. If you're interested I'll add test coverage of added code.

Screenshots (if appropriate):

Instead of this

image

Get this

image

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@9swampy 9swampy marked this pull request as ready for review June 23, 2025 01:26
@asbjornu
Copy link
Member

I wouldn't mind a test for this, but I don't think it's very important either. The code is rather trivial and this is a part of GitVersion that I'd almost say is "unsupported". :)

@asbjornu
Copy link
Member

Merging. If you want to write some tests for this, please submit them in a new PR. :)

@asbjornu asbjornu merged commit d095feb into GitTools:main Jun 24, 2025
93 checks passed
Copy link
Contributor

mergify bot commented Jun 24, 2025

Thank you @9swampy for your contribution!

@arturcic
Copy link
Member

@asbjornu is this also closing the reference issue? if so please include the issue in the milestore

@asbjornu
Copy link
Member

@arturcic, no #4585 isn't an issue, it's a vaguely related PR. Since this PR doesn't have an issue, I'll just add it to the 6.x milestone.

@asbjornu asbjornu added this to the 6.x milestone Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants