Add YamlDotNet source generator infrastructure for Native AOT support #4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Vecc.YamlDotNet.Analyzers.StaticGenerator package - Changed init properties to set properties to support source generator - Created GitVersionConfigurationStaticContext for AOT compatibility - Updated ConfigurationSerializer to use static serializer/deserializer - Updated PublicAPI.Unshipped.txt with generated API surface Co-authored-by: arturcic <[email protected]>
The YamlDotNet source generator has limitations: - Doesn't honor custom type inspectors for property naming - Limited support for dynamic types - The static context is kept for future use when generator improves All tests now pass with the regular serializers. Co-authored-by: arturcic <[email protected]>
Co-authored-by: arturcic <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
arturcic
October 8, 2025 18:48
|
arturcic
reviewed
Oct 8, 2025
| { | ||
| // Static context is defined for future AOT support but not currently used | ||
| // due to limitations with custom type inspectors and init properties | ||
| private static readonly GitVersionConfigurationStaticContext staticContext = new(); |
There was a problem hiding this comment.
@copilot I actually need to use the source generator version, and I will later check the AOT
There was a problem hiding this comment.
Pull Request Overview
This PR adds YamlDotNet source generator infrastructure to prepare GitVersion for Native AOT (Ahead-of-Time) compilation support. The infrastructure is implemented but not actively used due to current limitations in YamlDotNet's source generator capabilities.
- Added
Vecc.YamlDotNet.Analyzers.StaticGeneratorv16.3.0 package reference and createdGitVersionConfigurationStaticContextclass - Changed property accessors from
internal inittointernal setacross all configuration classes to support source generator requirements - Added documentation explaining current limitations and future migration path
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| YAMLDOTNET_SOURCE_GENERATOR.md | Documents implementation status, limitations, and future migration path |
| PublicAPI.Unshipped.txt | Adds generated types to public API surface |
| PreventIncrementConfiguration.cs | Changes 3 properties from init to set for generator compatibility |
| IgnoreConfiguration.cs | Changes 4 properties from init to set for generator compatibility |
| GitVersionConfigurationStaticContext.cs | New static context class with YamlDotNet source generator attributes |
| GitVersionConfiguration.cs | Changes 21 properties from init to set for generator compatibility |
| GitVersion.Configuration.csproj | Adds source generator package reference |
| ConfigurationSerializer.cs | Adds static context instance for future use |
| BranchConfiguration.cs | Changes 14 properties from init to set for generator compatibility |
| Directory.Packages.props | Adds version definition for source generator package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the YamlDotNet source generator infrastructure to prepare GitVersion for Native AOT (Ahead-of-Time) compilation support, as outlined in Using the YamlDotNet Source Generator for Native AOT.
Changes
1. Source Generator Package
Vecc.YamlDotNet.Analyzers.StaticGeneratorv16.3.0 package referenceGitVersionConfigurationStaticContextclass with[YamlStaticContext]and[YamlSerializable]attributes for main configuration types2. Property Accessor Updates
Changed
internal inittointernal setfor all configuration properties to support source generator requirements:BranchConfiguration(14 properties)GitVersionConfiguration(21 properties)IgnoreConfiguration(4 properties)PreventIncrementConfiguration(3 properties)This change maintains encapsulation (internal setters) while providing flexibility for serialization and future source generator use.
3. Updated Public API Surface
Added generated types to
PublicAPI.Unshipped.txt:GitVersionConfigurationStaticContextStaticTypeInspectorand related methodsCurrent Status
While the infrastructure is in place, the static serializer/deserializer is not actively used due to current limitations in YamlDotNet's source generator (v16.3.0):
StaticTypeInspectordoesn't honor custom type inspectors, which GitVersion requires forJsonPropertyNameattribute mappingDictionary<object, object?>used in override configurationsThe
ConfigurationSerializercurrently uses regularDeserializerBuilder/SerializerBuilderwith a comment explaining the situation. The static context is instantiated but kept ready for future use.Testing
✅ All 82 configuration tests pass (net8.0 and net9.0)
✅ Full backward compatibility maintained
✅ No breaking changes to existing functionality
Documentation
Added
YAMLDOTNET_SOURCE_GENERATOR.mddocumenting:Future Work
When YamlDotNet's source generator improves support for custom type inspectors and complex types, we can enable it in
ConfigurationSerializer.csby switching toStaticDeserializerBuilder/StaticSerializerBuilder.Related
Fixes #[issue_number]
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.