Implement basic URL scheme for Assistant & AI Search #3503
+289
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54c0db1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This reverts commit 6d99b32.
So that the case of `q=` and `ask=` is handled correctly
taranvohra
approved these changes
Jul 28, 2025
| @@ -5,6 +5,7 @@ import * as zustand from 'zustand'; | |||
| import { AIMessageRole } from '@gitbook/api'; | |||
| import * as React from 'react'; | |||
| import { useTrackEvent } from '../Insights'; | |||
| import { useSearch } from '../Search/useSearch'; | |||
There was a problem hiding this comment.
We should avoid nested imports. Export it from an index.ts
| // Close the pop-over when we switch to “ask” mode | ||
| React.useEffect(() => { | ||
| if (state?.ask && open && aiMode === CustomizationAIMode.Assistant) { | ||
| setSearchState((prev) => (prev ? { ...prev, open: false } : prev)); |
There was a problem hiding this comment.
Why do you need a conditional? Why can't it be just setSearchState(prev => ({ ...prev, open: false })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?q=always dictates the search state?ask=always dictates the AI Search / AI Assistant state.q=query&ask=true→ask=query&q=null