Conversation
Valley-15
requested a deployment
to
preview-approval
September 15, 2026 06:13 — with
GitHub Actions
Waiting
|
Valley-15
force-pushed
the
fix/4593-markdown-image-urls
branch
from
September 15, 2026 06:17
138d2d3 to
b44fcec
Compare
Valley-15
requested a deployment
to
preview-approval
September 15, 2026 06:17 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When generating Markdown versions of published pages, stable
/files/:idreferences inside raw HTMLsrcsetattributes were not being rewritten to their resolved file URLs.This caused image URLs such as:
to remain as
/files/:idreferences in the generated Markdown instead of resolving to the actual file URL.This change updates the existing HTML reference rewriting logic to also resolve
srcsetattributes using the same content-reference resolution already used for HTMLsrcattributes.Changes
/files/:idreferences in HTMLsrcsetattributes.srcreference behavior unchanged.srcandsrcsetfile references.Fixes #4593.
Validation
bun test packages/gitbook/src/lib/markdownPage.test.tsbun run --cwd packages/gitbook unitbun run format:checkbun run lintbun run --cwd packages/gitbook typecheckgit diff --checkAll checks pass.