feat: add interactive map to navigate to islands #27
+108
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierperez
reviewed
Feb 9, 2025
scenes/map/Map.tscn
Outdated
Comment on lines
23
to
32
| [node name="Island0Sprite" type="Sprite2D" parent="."] | ||
| unique_name_in_owner = true | ||
| position = Vector2(320, 220) | ||
|
|
||
| [node name="Clickable" parent="Island0Sprite" instance=ExtResource("1_3mm8m")] | ||
|
|
||
| [node name="Area2D" type="Area2D" parent="Island0Sprite/Clickable"] | ||
|
|
||
| [node name="CollisionShape2D" type="CollisionShape2D" parent="Island0Sprite/Clickable/Area2D"] | ||
| shape = SubResource("CircleShape2D_i4h8t") |
There was a problem hiding this comment.
As islands are the same, we might want to crate a custom node to reuse multiple times
scenes/map/map.gd
Outdated
Comment on lines
10
to
12
| # Called when the node enters the scene tree for the first time. | ||
| func _ready(): | ||
| pass |
There was a problem hiding this comment.
If we don't need this method we can remove it.
However, did you think about how the map will behave if we open it between the 2nd and the 3rd island? How to draw the ship just above the 2nd island?
scenes/map/map.gd
Outdated
| func _process(delta): | ||
| if (goal_island != null): | ||
| var island = _get_island(goal_island) | ||
| ship.position = ship.position.lerp(island.position, delta) |
There was a problem hiding this comment.
You may use move_toward to move an node if it's not a RigidBody2D
// with "ship_speed = 70" it looks nice
ship.position = ship.position.move_toward(island.position, delta * ship_speed)
scenes/map/map.gd
Outdated
| @onready var island_1: Sprite2D = %Island1Sprite | ||
| @onready var island_2: Sprite2D = %Island2Sprite | ||
|
|
||
| var goal_island = null |
There was a problem hiding this comment.
Instead of having an id, we can keep a reference to the node instead, so we wouldn't need to get it every frame
audreygentili
force-pushed
the
feat/create-interactive-map
branch
from
e2a8215 to
e2dde6b
Compare
audreygentili
force-pushed
the
feat/create-interactive-map
branch
from
e2dde6b to
9e390b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an interactive map scene after the main menu scene.
This new scene lets you navigate to islands on a ship.
When the ship reaches an island, the debug level scene appears.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: