Changed gyro widget to work with doubles - #147
Open
NaN0987 wants to merge 1 commit into
Open
Conversation
The gyro widget can now be applied to single-topic double values. It appears as a display option for doubles, and single-topic gyros will also have all of the display options for doubles.
Author
|
Closes #146 |
Owner
|
I think this is a very useful addition, however I think it could be implemented better I'd prefer making the widget subscribe only to the topic in the If you want help with any of it I would be willing to write/refactor some of the code. |
|
Would love to see this happen! 🙏 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gyro widget can now be applied to single-topic double values. It appears as a display option for doubles, and single-topic gyros will also have all of the display options for doubles.