Add Camera-Stream Crosshairs - #260
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 78.30% 78.12% -0.18%
==========================================
Files 93 93
Lines 9439 9570 +131
==========================================
+ Hits 7391 7477 +86
- Misses 2048 2093 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am not going to lie, I am not quite sure how to test custom painters. From what I have seen online, the main way to do it is to have an image that has the specific overlay from the CustomPainter already done, and to then compare it pixel by pixel during the test. |
f3b8d8f to
b0fabcf
Compare
Gold872
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I can see where this feature would be useful, however I'm not sure whether it makes sense for the dashboard to implement positioning and highly detailed controls over thickness and appearance. For most scenarios, this would already be done by a camera coprocessor.
I'd like to hear your thoughts on this, it's not a matter of complexity, but a matter of whether it fits within the needs of a driver dashboard
|
I think that it should be a feature on the dashboard for a few reasons Just my thoughts. |
I've always wanted a dashboard that handled crosshairs, even before becoming a PV maintainer and having substantial reason to not want to implement customizable crosshairs ;) On the technical side, crosshairs that are embedded in the camera stream itself kinda suck. They're a lossy operation on the image (meaning you can't feed the image back into an AprilTag detector and get the same results), and at low resolutions (which are common due to bandwidth limitations), the crosshair is both barely visible and takes up way more space than it deserves to. Moving the crosshair to the dashboard side would allow greater flexibility than having it embedded in the video stream. |
|
I give up on trying to get the formatting to work 😭. |
a498a45 to
439c095
Compare
|
Any idea if this feature will be included or any changes should be made? |

Resolves #226.
Allows users to create a crosshair with an x, y, thickness, height, width, and color.
Todo: