Skip to content

Add Keybinds List to Help Menu - #332

Open
EmeraldWither wants to merge 14 commits into
Gold872:mainfrom
EmeraldWither:keybinds_help
Open

Add Keybinds List to Help Menu#332
EmeraldWither wants to merge 14 commits into
Gold872:mainfrom
EmeraldWither:keybinds_help

Conversation

@EmeraldWither

Copy link
Copy Markdown
Contributor
image

This PR adds a keybinds help page to Elastic, since it isn't nicely documented in one place anywhere. The keybinds are added dynamically based on what Hotkeys are registered using HotkeyManager (so adding extra hotkeys should appear here automatically), and are then converted to an intermediatory KeybindCaterory/Keybind class so it can be easily represented, tested, and then rendered to the screen. Everything should be unit tested.

@github-actions github-actions Bot added the GUI Changes to Elastic's UI label Jan 13, 2026
@codecov

codecov Bot commented Jan 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.06623% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.47%. Comparing base (3c934b8) to head (bb1364b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/widgets/keybinds_dialog.dart 91.66% 8 Missing ⚠️
lib/pages/dashboard_page.dart 86.79% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   78.30%   78.47%   +0.17%     
==========================================
  Files          93       94       +1     
  Lines        9439     9565     +126     
==========================================
+ Hits         7391     7506     +115     
- Misses       2048     2059      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gold872 Gold872 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I'll take a closer look at the KeybindsDialog implementation at a later point (it looks really complex) but I like this addition

Comment thread lib/pages/dashboard/dashboard_keybinds_window.dart Outdated
Comment thread lib/pages/dashboard_page.dart Outdated
Comment thread lib/widgets/keybinds_dialog.dart Outdated
Comment thread lib/widgets/keybinds_dialog.dart Outdated
@EmeraldWither
EmeraldWither requested a review from Gold872 January 14, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Changes to Elastic's UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants