Add Keybinds List to Help Menu - #332
Open
EmeraldWither wants to merge 14 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 78.30% 78.47% +0.17%
==========================================
Files 93 94 +1
Lines 9439 9565 +126
==========================================
+ Hits 7391 7506 +115
- Misses 2048 2059 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gold872
requested changes
Jan 14, 2026
Gold872
left a comment
Owner
There was a problem hiding this comment.
This looks really good. I'll take a closer look at the KeybindsDialog implementation at a later point (it looks really complex) but I like this addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a keybinds help page to Elastic, since it isn't nicely documented in one place anywhere. The keybinds are added dynamically based on what Hotkeys are registered using HotkeyManager (so adding extra hotkeys should appear here automatically), and are then converted to an intermediatory KeybindCaterory/Keybind class so it can be easily represented, tested, and then rendered to the screen. Everything should be unit tested.