Skip to content

Add layout downloading port option - #345

Open
httphypixelnet wants to merge 2 commits into
Gold872:mainfrom
3681NHR:feat/layout-ports
Open

Add layout downloading port option#345
httphypixelnet wants to merge 2 commits into
Gold872:mainfrom
3681NHR:feat/layout-ports

Conversation

@httphypixelnet

Copy link
Copy Markdown

This PR aims to fix #246, giving users the option to use a custom port for the "Download from Robot" web server. I didn't actually add a unit test for that functionality specifically, but I integrated the preferences key into existing unit tests, and tested that it worked manually.

@github-actions github-actions Bot added the GUI Changes to Elastic's UI label Feb 26, 2026
@codecov

codecov Bot commented Mar 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.64103% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.90%. Comparing base (3673f6b) to head (2e2a251).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/dashboard/dashboard_page_settings.dart 3.70% 26 Missing ⚠️
lib/widgets/settings_dialog.dart 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   78.12%   77.90%   -0.23%     
==========================================
  Files          93       93              
  Lines        9436     9473      +37     
==========================================
+ Hits         7372     7380       +8     
- Misses       2064     2093      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Changes to Elastic's UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow Elastic to use a different port for the webserver

1 participant