Refactor Notification constructor to use constants - #378
Open
DanPeled wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 95 95
Lines 9587 9587
=======================================
Hits 7537 7537
Misses 2050 2050 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
auscompgeek
reviewed
Jul 16, 2026
|
|
||
| private static final int DEFAULT_DISPLAY_TIME = 3000; | ||
| private static final double DEFAULT_WIDTH = 350; | ||
| private static final double AUTO_HEIGHT = -1; |
There was a problem hiding this comment.
- Is there any reason these shouldn't be public?
- The C++ version calls this
AUTOMATIC_HEIGHT. Any reason for this to diverge?
Contributor
Author
There was a problem hiding this comment.
No reason for both, didn't notice the divergence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.